Skip to content

solara.js.org #9695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2025
Merged

solara.js.org #9695

merged 1 commit into from
Apr 16, 2025

Conversation

getsolarajs
Copy link
Contributor

The site content is https://github.com/getsolarajs/solara-docs/tree/main

@MattIPv4 MattIPv4 changed the title Update cnames_active.js solara.js.org Apr 14, 2025
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, CNAME present, site appears to have content *

* based off https://github.com/getsolarajs/solara-docs/tree/main/docs

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account labels Apr 14, 2025
@indus indus added the no content This PR has a target that contains no valid content for a request label Apr 15, 2025
@indus
Copy link
Member

indus commented Apr 15, 2025

I've already added your requested subdomain to JS.ORGs zonefile. But your page seems to have no content (besides the title). I've seen the MD-Guides in the repo but they don't show up on the page

As stated in the readme I'm not accepting requests for pages without content.

You will have to fix that before I will merge... Please keep this PR open.

@indus indus removed the no content This PR has a target that contains no valid content for a request label Apr 16, 2025
@indus
Copy link
Member

indus commented Apr 16, 2025

Looks good to me now.

Welcome https://solara.js.org

@indus indus merged commit 4a6330e into js-org:master Apr 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants